Re: [PATCH 365] Only complain that files are up-to-date with --force.

[Gary V. Vaughan]

On 22 Apr 2008, at 16:16, Ralf Wildenhues wrote:
> Hi Gary,

Hallo Ralf,

Thanks again for the fast review :-)

> * Gary V. Vaughan wrote on Tue, Apr 22, 2008 at 08:49:54AM CEST:
> > Okay to Apply?
>
> I'd say yes.
>
> > +      my_msg=`eval echo \\\$$1`
>
> Can this line be simplified to
>  eval my_msg=\$$1
> ?

Yes indeed.

> > +        eval $1=""
>
> Those double quotes are pretty superfluous, as they won't survive the
> eval.  Not that they are a problem at all.  :-)

I quite like the fact that the say to the reader: "this variable is  
being
set to the empty string", so I'm inclined to leave them.

> > +sed "s/^libtoolize/$lt_name/
> > +s,/usr/local/share/aclocal/,$abs_top_srcdir/libltdl/m4/," < $1 >  
> > $1.t
>
> Maybe better use | as sed s command delimiter in the last line?


Good call.  Thanks.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_

PGP.sig
Description: This is a digitally signed message part