Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Charles Wilson on 5/5/2008 6:23 PM:

| 2008-05-05  Charles Wilson  <...>
|
|       Ensure cwrapper compiles without warnings under -std=c99.
|

Looks ok, except for these nits:

|
| -# func_emit_wrapper arg
| +# func_emit_wrapper_part1 arg

Since you provide a default, I'd show that arg is optional, as in:

# func_emit_wrapper_part1 [arg=no]

| -     func_emit_wrapper_arg1=no
| +     func_emit_wrapper_part1_arg1=no
|       if test -n "$1" ; then
| -       func_emit_wrapper_arg1=$1
| +       func_emit_wrapper_part1_arg1=$1
|       fi
|
|       $ECHO "\
| @@ -2352,10 +2352,36 @@ else
|      file=\`\$ECHO \"X\$file\" | \$Xsed -e 's%^.*/%%'\`
|      file=\`ls -ld \"\$thisdir/\$file\" | ${SED} -n 's/.*-> //p'\`
|    done
| +"
| +}

Is func_emit_wrapper_part1_arg1 even used?  Why not just delete it?

| @@ -2658,7 +2724,8 @@ EOF
|             esac
|
|           cat <<EOF
| -       printf ("%s", script_text);
| +       printf ("%s", script_text_part1);
| +       printf ("%s", script_text_part2);

Isn't puts slightly more efficient than printf?  But it doesn't matter
that much to me.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkggT98ACgkQ84KuGfSFAYAEnQCgtdrwKsc03LVrCbRUhhvzPReJ
NAwAoMPFiFmFnXy110ub4AksCv6fLuAD
=jLOb
-----END PGP SIGNATURE-----