Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

[Charles Wilson]

Ralf Wildenhues wrote:
> Hi Charles,
> You can simplify the remaining part of the ChangeLog entry:
> or even to this:
>         (func_emit_cwrapperexe_src) [lt_setenv, lt_extend_str]
>         [lt_split_name_value, lt_opt_process_env_set]
>         [lt_opt_process_env_prepend, lt_opt_process_env_append]
>         [lt_update_exe_path, lt_update_lib_path]: New functions.

I'll try to remember to update that when I squash my topic-branch commits.

> More nits:
>
> > +# func_to_native_path
> > +#
> > +# intended for use on "native" mingw (where libtool itself
>
> Please capitalize, also please start the description with what the
> function does, not what it is intended for:
>   Convert paths to build format when used with build tools.
>   [...]

Done.

> > +      char *new_value = lt_extend_str (getenv (name), value, 0);
> > +      /* some systems can't cope with a ':'-terminated path #' */
>
> What does that #' do here?

See reply to Eric.

> Sorry I haven't had the time to test your patches on a cross build yet.
> (This isn't a veto against the patch.)

Gary mentioned you were buried this week, and I knew this one had no 
chance for 2.2.4.  Now, 2.2.6, maybe...

--
Chuck