libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 350-gary-maintain-private-libobj-namespace


From: Eric Blake
Subject: Re: 350-gary-maintain-private-libobj-namespace
Date: Mon, 19 May 2008 16:02:47 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Eric Blake <ebb9 <at> byu.net> writes:

> |> * libltdl/m4/ltdl.m4 (_LT_LIBSOURCES): Delete.
> |> (LTDL_INIT): Ignore arguments to AC_LIBSOURCES during _LTDL_SETUP,
> |> on the assumption that libtoolize correctly installed them.
> |
> |
> | Looks good to me.  Please apply.
> 
> Applied.

Bah.  I had tested with libtool, but not with m4; had I done so, I would not 
have caused the problem of referring to the now undefined _LT_LIBSOURCES.  
Committing this as an obvious followup.

>From d4aec62a7e0eae9bfd94ca2620e0771a85a77476 Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Mon, 19 May 2008 08:18:33 -0600
Subject: [PATCH] Fix regression from two days ago.

* libltdl/m4/ltdl.m4 (_LT_LIBOBJ): Don't refer to deleted macro.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog          |    5 +++++
 libltdl/m4/ltdl.m4 |    1 -
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 853adbb..e60db3d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-05-19  Eric Blake  <address@hidden>
+
+       Fix regression from two days ago.
+       * libltdl/m4/ltdl.m4 (_LT_LIBOBJ): Don't refer to deleted macro.
+
 2008-05-17  Eric Blake  <address@hidden>
 
        Speed up bootstrap by improving lt_combine.
diff --git a/libltdl/m4/ltdl.m4 b/libltdl/m4/ltdl.m4
index cdb94e6..3908963 100644
--- a/libltdl/m4/ltdl.m4
+++ b/libltdl/m4/ltdl.m4
@@ -212,7 +212,6 @@ m4_define([$0], [])
 # of into LIBOBJS.
 AC_DEFUN([_LT_LIBOBJ], [
   m4_pattern_allow([^_LT_LIBOBJS$])
-  AS_LITERAL_IF([$1], [_LT_LIBSOURCES([$1.c])])dnl
   _LT_LIBOBJS="$_LT_LIBOBJS $1.$ac_objext"
 ])# _LT_LIBOBJS
 
-- 
1.5.5.1








reply via email to

[Prev in Thread] Current Thread [Next in Thread]