libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Linking with '-L /path/to/lib' (note the space!)


From: Ralf Wildenhues
Subject: Re: Linking with '-L /path/to/lib' (note the space!)
Date: Thu, 21 Aug 2008 22:27:35 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

* Ralf Wildenhues wrote on Thu, Aug 21, 2008 at 09:11:16PM CEST:
> * Bob Friesenhahn wrote on Thu, Aug 21, 2008 at 09:09:50PM CEST:
> > On Thu, 21 Aug 2008, Ralf Wildenhues wrote:
> >>
> >> Well, libtool *could* also remove the space.  I'm just not sure whether
> >> it's worth supporting this.
> >
> > Removing the space might simply cause a failure later if it is an actual 
> > typo (like your test case).
> 
> Good point.  Thanks for giving me an argument to commit this.  :-)

Sigh.  I should've run the whole testsuite first.  Fixed thusly.

2008-08-21  Ralf Wildenhues  <address@hidden>

        * libltdl/config/ltmain.m4sh (func_mode_link): Quote $#.

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index d1c984c..590252e 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -4036,7 +4036,7 @@ func_mode_link ()
        func_stripname '-L' '' "$arg"
        dir=$func_stripname_result
        if test -z "$dir"; then
-         if test $# -gt 0; then
+         if test "$#" -gt 0; then
            func_fatal_error "require no space between \`-L' and \`$1'"
          else
            func_fatal_error "need path for \`-L' option"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]