libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 3


From: Ralf Wildenhues
Subject: Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 3
Date: Mon, 19 Jan 2009 23:56:19 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Hi Charles,

* Charles Wilson wrote on Fri, Jan 16, 2009 at 02:51:21PM CET:
> The "unexpected" failure was
>  36: execute mode         FAILED (execute-mode.at:193)
> but it is unrelated; it's a problem in cygwin-1.7's "dos-style path
> detection"...That's not a path!
> 
> --- /dev/null   2006-11-30 19:00:00.000000000 -0500
> +++
> /usr/src/packages/libtool/git/build-cygwin-dlpreopen-fix-take2/tests/testsui
> te.dir/at-groups/36/stderr      2009-01-15 23:50:30.981800000 -0500
> @@ -0,0 +1,6 @@
> +cygwin warning:
> +  MS-DOS style path detected: d\"e
> +  Preferred POSIX equivalent is: d/"e
> +  CYGWIN environment variable option "nodosfilewarning" turns off this
> warning.
> +  Consult the user's guide for more details about POSIX paths:
> +    http://cygwin.com/cygwin-ug-net/using.html#using-pathnames
> stdout:
> abc
> d\"e
> f\"g
> xyz
> 36. execute-mode.at:25: 36. execute mode (execute-mode.at:25): FAILED 
> (execute-mode.at:193)

Thanks.  Applying this to avoid this failure.

Cheers,
Ralf

        Avoid failure due to Cygwin path detection bug.
        * tests/execute-mode.at (execute mode): Ignore noise on stderr;
        Cygwin might consider `d\"e' to be a DOS-style path and warn.
        Report by Charles Wilson.

diff --git a/tests/execute-mode.at b/tests/execute-mode.at
index c3370da..a73cada 100644
--- a/tests/execute-mode.at
+++ b/tests/execute-mode.at
@@ -1,6 +1,6 @@
 # execute-mode.at -- libtool --mode=execute             -*- Autotest -*-
 #
-#   Copyright (C) 2008 Free Software Foundation, Inc.
+#   Copyright (C) 2008, 2009 Free Software Foundation, Inc.
 #   Written by Ralf Wildenhues, 2008
 #
 #   This file is part of GNU Libtool.
@@ -190,7 +190,7 @@ do
   if test -z "$arg1"; then
     arg1=$arg2; continue
   fi
-  AT_CHECK([$LIBTOOL --mode=execute ./foo abc "$arg1" "$arg2" xyz], [], 
[stdout])
+  AT_CHECK([$LIBTOOL --mode=execute ./foo abc "$arg1" "$arg2" xyz], [], 
[stdout], [ignore])
   AT_CHECK([$FGREP "$arg1" stdout], [], [ignore])
   AT_CHECK([$FGREP "$arg2" stdout], [], [ignore])
   AT_CHECK([test `sed -n '/^abc$/,/^xyz$/p' stdout | wc -l` -eq 4])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]