Re: "Run tests with low max_cmd_len" on MSYS/MSVC

[Ralf Wildenhues]

Hi Peter,

* Peter Rosin wrote on Wed, Jan 21, 2009 at 02:26:36AM CET:
> This patch together with [1] and [2] will make "Run tests with
> low max_cmd_len" on MSYS/MSVC behave the same as the individual
> tests.
>
> The patch fixes a couple more of the /abs/path issues already
> fixed in [1] and [2]. However, I fear that these hunks may be
> more controversial, as they touch code that affects other
> platforms as well.

Well, for non-w32 systems the patch is pretty obviously ok, as
func_to_host_path doesn't do much there, and not slowly.  :-)

For Cygwin and MinGW, it will likely make things much slower, since
this will cause lots of forks.  From a correctness perspective, the
patch looks good to go, though.

We may need to think about speeding up func_to_host_path, e.g., by not
forking for arguments that don't need conversion, or by converting
several paths with a constant amount of forks.  But that can be done
separately.

Thanks,
Ralf

> [1] http://lists.gnu.org/archive/html/libtool-patches/2009-01/msg00090.html
> [2] http://lists.gnu.org/archive/html/libtool-patches/2009-01/msg00092.html
>
> 2009-01-21  Peter Rosin  <address@hidden>
>
>       Convert paths to host format
>       * libltdl/config/ltmain.m4sh (func_mode_link): When exporting
>       symbols, linking and creating archives using command files (or
>       response files), make sure that both the name of the command
>       file and the content are made up of file names in a format
>       appropriate for the host. Fixes stresstest.at on MSYS/MSVC when
>       run with low command line length.