Re: Unify line endings in localization test

[Ralf Wildenhues]

Hi Peter,

* Peter Rosin wrote on Thu, Jan 22, 2009 at 10:57:20AM CET:
>>> Something like the attached?
>>
>> Yes, with nits below addressed.

> Ok, so push to master or pr-msvc-support?

This change is ok for both.  However, let's move away from manual
addition of the same change to more than one public branch.  How about
you do either one of these:

1) create, in your own repository, a new branch pr-tests-newline-fixes
containing this one patch, then merge this patch into both
pr-msvc-support and into master, then push the last two (no need to ever
push pr-tests-newline-fixes),
2) add the patch to master and merge master into pr-msvc-support, and
then push both branches,
3) or, if you feel unsure, I can do either of (1) or (2) for you.

I'd recommend that you use the git-merge-changelog driver from gnulib
for merging ChangeLog entries, and I would also like to see that log
entries appear in in the ChangeLog file in the order that patches are
applied to master.  Whether they contain updated dates or not, I am not
so sure about, but I think GCS encourages that.  So merging of the
ChangeLog might entail a bit of manual work after all.

> And one more thing I just
> realized, on MinGW the two-arg version leaves FILE intact which does
> not happen for other hosts. Should that be fixed?

Yes.  And the resulting semantics documented in the macro header.
Good catch.

> With an rm for MinGW or with cp instead of the mv for others?

Hmm.  cp?

Thanks,
Ralf

> 2009-01-22  Peter Rosin  <address@hidden>
>
>       Unify line endings in localization test.
>       * tests/testsuite.at: Update copyright year.
>       (LT_AT_UNIFY_NL): Add macro that unifies line endings on
>       platforms that suffer from such confusion.
>       * tests/localization.at: Use it. Update copyright year. Fixes
>       the test on MSYS/MSVC.