Re: Add lib prefix to library name in the ltdl preloaded symbol lookup

[Peter Rosin]

Den 2009-01-26 21:19 skrev Charles Wilson:
> Peter Rosin wrote:
> > This is from need-lib-prefix.at: main.exeS.c when the test
> > is run on the tip of the pr-msvc-support branch.
> >
> >     lt__PROGRAM__LTX_preloaded_symbols[] =
> >     {  { "@PROGRAM@", (void *) 0 },
> >       {"foo1.lib", (void *) 0},
> >       {"libfoo1_LTX_i", (void *) &foo1_LTX_i},
> >       {"libfoo1_LTX_f", (void *) &foo1_LTX_f},
> >
> > The below patch makes that into
> >
> >       {"libfoo1.lib", (void *) 0},
> >       {"libfoo1_LTX_i", (void *) &foo1_LTX_i},
> >       {"libfoo1_LTX_f", (void *) &foo1_LTX_f},
> >
> > which works much better.
> >
> > The need-lib-prefix.at test still works on Cygwin after this test.
>
> Did you test this in conjunction with the "[cygwin|mingw] fix dlpreopen
> with --disable-static take 4" changes, or do I need to do that?  Also,
> what if the library is not "libfooN.lib", but is instead "cygfoo-N.dll"
> (or "foo-N.dll") -- which is another way of asking the same question, I
> guess?

Ooops, sorry for broadsiding your pending patch like that, I failed to
notice the clash...

Please ignore my patch for now, and I'll do tests here before I resubmit
(once yours is through the queue).

But if you have some time, what tests to you think are likely
to belly up with yours and my changes combined?

Cheers,
Peter