libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Repost: [PATCH] [cygwin|mingw] Create UAC manifest files.


From: Charles Wilson
Subject: Repost: [PATCH] [cygwin|mingw] Create UAC manifest files.
Date: Sun, 21 Feb 2010 01:31:15 -0500
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

2010-02-21  Yaakov Selkowitz  <...>
            Charles Wilson  <...>

        [cygwin|mingw] Create UAC manifest files.

        * libltdl/config/ltmain.m4sh (func_emit_exe_manifest): New
        function.
        (func_mode_link) [cygwin|mingw]: Create manifest files for
        wrapper and target exe when target name matches heuristic that
        triggers UAC problems for newer win32 OSs. Clean up
        $cwrapper.manifest on error. Ensure manifest files have
        executable permission.
        (func_mode_uninstall): Clean up manifest files.
        Various reports by Eric Blake, Kai Tietz, and Cesar Strauss.

This is a revised version of Yaakov's original patch, that addresses
(most of) the comments received previously. Original posted:
http://lists.gnu.org/archive/html/libtool-patches/2009-06/msg00058.html


The only comment NOT addressed by this version is: Peter Rosin doesn't
want this code activated for msvc, but I'm not sure this patch should be
modified to guard against a compiler, whose support (in Peter's branch)
has not itself yet been merged into master.  And I don't know what
symbol to use; maybe Peter's branch has a special variable that should
be tested?

Anyway, IF this patch should be modified to "protect" msvc, I'd sure
like somebody to tell me how that should be done:

              # note: this script will not be executed, so do not chmod.
              if test "x$build" = "x$host" ; then
+               # Create the UAC manifests first if necessary (but the
+               # manifest files must have executable permission
regardless).

like this, maybe:
                if [ $CC != msvc ]; then

+               case $output_name in
+                 *instal*|*patch*|*setup*|*update*)

Or tell me that such protection should be deferred until Peter's stuff
is merged?

FYI, Yaakov has submitted all the necessary copyright papers and
received acknowledgement from the FSF.

--
Chuck

Attachment: 0026-cygwin-mingw-Create-UAC-manifest-files-rev2.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]