Re: make dist failure

[Ralf Wildenhues]

* Peter Rosin wrote on Wed, Jun 09, 2010 at 09:00:06AM CEST:
> Den 2010-06-09 07:14 skrev Ralf Wildenhues:
> >I would like to see more of the story here.  If this is still
> >reproducible for you, post the output of
> >   make check-local TESTSUITEFLAGS='-v -d -x 77'
> 
> It is very reproducible, even on a frech clone.

Indeed, with a fresh clone, I can reproduce it too:

| $ diff -u fresh-clone/libltdl/Makefile.in longtime-tree/libltdl/
| --- fresh-clone/libltdl/Makefile.in 2010-06-09 19:49:55.000000000 +0200
| +++ longtime-tree/libltdl/Makefile.in 2010-06-09 19:31:37.000000000 +0200
| @@ -46,8 +46,8 @@
|         $(srcdir)/Makefile.in $(srcdir)/config-h.in \
|         $(top_srcdir)/configure COPYING.LIB argz.c config/compile \
|         config/config.guess config/config.sub config/depcomp \
| -       config/install-sh config/ltmain.sh config/mdate-sh \
| -       config/missing config/texinfo.tex lt__dirent.c lt__strl.c
| +       config/install-sh config/ltmain.sh  \
| +       config/missing  lt__dirent.c lt__strl.c
|  ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
|  am__aclocal_m4_deps = $(top_srcdir)/m4/argz.m4 \
|         $(top_srcdir)/m4/libtool.m4 $(top_srcdir)/m4/ltdl.m4 \


That's a bug in the bootstrap procedure, or depending on how you look at
things, in the way you work.  ;-)  Things should work if you add
  make all

between the configure call and the 'make check-local' call.
The patch below should let you be able to forget this again.

> >Can you look if installcheck (same args as above) gives a similar
> >problem?  make install should be taking care of the timestamps for
> >installed files (but make all should do so for the uninstalled ones,
> >too ...)
> 
> I'm not sure what you mean here, but if I do "make installcheck"
> in the .../testsuite.dir/077 directory after the failure, is says:
> make: Nothing to be done for `installcheck'.

Sorry for not being clear.  I really meant running this in the toplevel
build directory:
  make install installcheck TESTSUITEFLAGS='-v -d -x 75'

OK to commit this hack to work around the issue?

Thanks,
Ralf

        Ensure libltdl is up to date for check-local.
        
        * Makefile.am (LTDL_BOOTSTRAP_DEPS): New variable.
        (all-local): Use it to simplify dependencies.
        (testsuite_deps_uninstalled): Add $(LTDL_BOOTSTRAP_DEPS).
        Report by Peter Rosin.

diff --git a/Makefile.am b/Makefile.am
index a7de46d..7c7f571 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -256,11 +256,13 @@ $(srcdir)/libltdl/Makefile.am: 
$(srcdir)/libltdl/Makefile.inc
 
 ## Unfortunately, all this bogeyness means that we have to manually
 ## keep the generated files in libltdl up to date.
-all-local: $(srcdir)/libltdl/aclocal.m4 \
+LTDL_BOOTSTRAP_DEPS = $(srcdir)/libltdl/aclocal.m4 \
        $(srcdir)/libltdl/stamp-mk \
        $(srcdir)/libltdl/configure \
        $(srcdir)/libltdl/config-h.in
 
+all-local: $(LTDL_BOOTSTRAP_DEPS)
+
 EXTRA_DIST += $(srcdir)/libltdl/stamp-mk $(m4dir)/lt~obsolete.m4
 
 $(srcdir)/libltdl/Makefile.in: $(srcdir)/libltdl/Makefile.am \
@@ -558,7 +560,8 @@ DISTCLEANFILES += tests/atconfig
 CD_TESTDIR     = abs_srcdir=`$(lt__cd) $(srcdir) && pwd`; cd tests
 
 testsuite_deps = tests/atconfig $(srcdir)/$(TESTSUITE)
-testsuite_deps_uninstalled = $(testsuite_deps) libltdl/libltdlc.la 
$(bin_SCRIPTS)
+testsuite_deps_uninstalled = $(testsuite_deps) libltdl/libltdlc.la \
+                            $(bin_SCRIPTS) $(LTDL_BOOTSTRAP_DEPS)
 
 # Hook the test suite into the check rule
 check-local: $(testsuite_deps_uninstalled)