[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Use getopt.m4sh to generate libtoolize option parser.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Use getopt.m4sh to generate libtoolize option parser. |
Date: |
Thu, 10 Jun 2010 18:54:33 +0200 |
User-agent: |
Mutt/1.5.20 (2009-10-28) |
Hi Gary,
* Gary V. Vaughan wrote on Thu, Jun 10, 2010 at 05:18:08PM CEST:
> Okay to push?
Some of the $ECHO use ($ECHO "$opt") now became plain echo, that might
be a problem with backslashes or leading single hyphens. Otherwise, it
looks to me like with
--ltdl=foo --ltdl=bar
the old version used the last, whereas the new one uses the first
option.
It is a bit confusing to see things like $NL2SP initialized later in the
script than it is used, although that is probably ok since the use is
inside a function. If that's easily fixed though, that might be better?
Or is it that we're guaranteed there is no out-of-function code until
the very end? You decide.
(I'm looking at a diff of the old and the new generated libtoolize
scripts.)
OK with those things fixed, and if the testsuite still passes.
Thanks,
Ralf
> * libtoolize.m4sh: Replace hand written shell code with a
> call to M4SH_GETOPTS. Move some premature initialization
> from the preamble to the main part of the script. Exit with
> an error on spurious additional non-option arguments.
> (envopts): Integrate LIBTOOLIZE_OPTIONS pre-parsing into the
> main option parsing loop.
> (opt_copy): Use in place of and in the reverse sense of the
> old opt_link variable.