libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MSVC: For MSVC, embed the manifest as a resource in the executable.


From: Ralf Wildenhues
Subject: Re: MSVC: For MSVC, embed the manifest as a resource in the executable.
Date: Wed, 23 Jun 2010 21:02:13 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

Hi Peter,

* Peter Rosin wrote on Wed, Jun 23, 2010 at 04:47:45PM CEST:
> "For MSVC, embed the manifest as a resource in the executable."
> 9f550cb81d4dfe4fc8962f23a7eccb1152e5c4a5
> 
> and the relevant part of
> 
> "patch msvc-documentation.patch"
> 06cfce005204bb8ca212aadab38b38c0202ea04e

This patch assumes that 'mt' is present, is what you think it is, and
doesn't allow an override.  On my GNU/Linux, mt is part of cpio and
controls magnetic tapes.  Is there possibility for similar confusion on
w32, or want of choice of a different mt version?  This should probably
use AC_CHECK_TOOL or so for this, and an _LT_DECL, similar to how
objdump, dlltool are handled in ltoptions.m4, but defaulting to ':' not
false.  Not that I can imagine anyone prefixing it with `$host-'.  But
it's probably prudent to check that it accepts -? or so (be sure to
quote the ?).

I'm assuming that we will rework manifest handling later again anyway,
but for now it doesn't look like this can make things any worse other
than above note.  So, with that addressed, please repost and wait 72h
before committing.

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]