[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFT PATCH v3 3/9] add --with-sysroot
From: |
Paolo Bonzini |
Subject: |
Re: [RFT PATCH v3 3/9] add --with-sysroot |
Date: |
Thu, 29 Jul 2010 10:17:28 +0200 |
On Thu, Jul 29, 2010 at 10:01, Charles Wilson
<address@hidden> wrote:
> On 7/28/2010 7:23 PM, Paolo Bonzini wrote:
>> * libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New.
>> (LT_SETUP): Require _LT_WITH_SYSROOT.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> Right now the default is to use a sysroot.
>
> Are you sure about this?
>
>> +AC_ARG_WITH([sysroot],
>> +[ --with-sysroot[=DIR] Search for dependent libraries within DIR
>> + (or the compiler's sysroot if not specified).],
>> +[], [with_sysroot=no])
>
> The fouth argument is the default action (what to do with --*-sysroot is
> not specified). But:
>
> +lt_sysroot=
> +case ${with_sysroot} in #(
> ...
> + no)
> + ;; #(
> ...
>
> e.g. do nothing special. Seems like you'd want the default action to be
> with_sysroot=yes, for the comment (and NEWS entry) to be correct.
No, seems like I was too tired as well. :)
Paolo
- [RFT PATCH v3 0/9] Sysroot patches, Paolo Bonzini, 2010/07/28
- [RFT PATCH v3 1/9] fix bug in postdeps computation, Paolo Bonzini, 2010/07/28
- [RFT PATCH v3 2/9] handle sysroot flags, Paolo Bonzini, 2010/07/28
- [RFT PATCH v3 3/9] add --with-sysroot, Paolo Bonzini, 2010/07/28
- [RFT PATCH v3 4/9] teach libtool -L= and -R=, Paolo Bonzini, 2010/07/28
- [RFT PATCH v3 6/9] process postdeps to include sysrooted paths, Paolo Bonzini, 2010/07/28
- [RFT PATCH v3 7/9] emit sysrooted paths when installing .la files, Paolo Bonzini, 2010/07/28
- [RFT PATCH v3 9/9] initial version of the NEWS entry, Paolo Bonzini, 2010/07/28
- [RFT PATCH v3 8/9] add sysroot test, Paolo Bonzini, 2010/07/28
- [RFT PATCH v3 5/9] handle sysrooted paths when reading dependencies to la files, Paolo Bonzini, 2010/07/28
- Re: [RFT PATCH v3 0/9] Sysroot patches, Charles Wilson, 2010/07/29