[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFT PATCH v4 0/8] Sysroot series

From: Ralf Wildenhues
Subject: Re: [RFT PATCH v4 0/8] Sysroot series
Date: Sun, 1 Aug 2010 20:43:46 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:26PM CEST:
>   handle sysroot flags
>   add --with-sysroot
>   teach libtool -L= and -R=
>   handle sysrooted paths when reading dependencies to la files
>   process postdeps to include sysrooted paths
>   emit sysrooted paths when installing .la files
>   add sysroot test
>   initial version of the NEWS entry

The overall series looks fairly good to me, thanks to you and Charles
for the hard work on it.  Please s/2009/2010/ in the new testsuite file,
and spaces before open parentheses for C and shell functions, thanks.

I can't really give a good review of the rest without a sysrooted
compiler, and I don't have time to build one any more this weekend,
so I'd appreciate if you could post output of
  make check-local TESTSUITEFLAGS='-v -d -x -k sysroot'

for both w32 and GNU/Linux (and other systems you happen to be able to
test); thanks.  Might still take me until next weekend though, sorry.

After nits have been addressed, also please feel free to push the patch
series to a temporary git branch (off of master) on savannah.  I expect
that it will be mergeable with minor corrections.  I really do think
however that a libtool.texi update would be fairly important to have.

Also, I still don't quite understand why this is unusable when the
compiler is not sysrooted, so an explanation would be nice.  For
example, the w32 cross compiler package on Debian is not sysrooted.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]