[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
fix pic_flag test (was: [RFT PATCH v4 0/8] Sysroot series)
From: |
Ralf Wildenhues |
Subject: |
fix pic_flag test (was: [RFT PATCH v4 0/8] Sysroot series) |
Date: |
Mon, 2 Aug 2010 22:21:48 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Charles Wilson wrote on Mon, Aug 02, 2010 at 05:23:28AM CEST:
> The "unexpected" failure was
> 112: override pic_flag at configure time FAILED (pic_flag.at:48)
> which isn't a regression on cygwin.
I'm pushing this patch to fix two issues with the test case.
Really should've known better than to use grep -e ...
Thanks for the report,
Ralf
Fix pic_flag test unportabilities.
* tests/pic_flag.at (override pic_flag at configure time): Skip
test if the compiler produces a warning containing `fpic'.
Do not use nonportable `grep -e', for Solaris.
Report by Charles Wilson.
diff --git a/tests/pic_flag.at b/tests/pic_flag.at
index a729d16..e62e1b7 100644
--- a/tests/pic_flag.at
+++ b/tests/pic_flag.at
@@ -34,7 +34,9 @@ int func(void) { return data; }
cp foo.c foo.cpp
C_pic_flag='-fpic -DPIC'
AT_CHECK([$CC $CPPFLAGS $CFLAGS $C_pic_flag -c foo.c || exit 77],
- [], [ignore], [ignore])
+ [], [stdout], [stderr])
+# The configure test for the PIC flag also checks for warnings.
+AT_CHECK([grep fpic stdout stderr && exit 77], [1])
CXX_pic_flag='-fpic -DPIC'
if $CXX $CPPFLAGS $CXXFLAGS $CXX_pic_flag -c foo.cpp; then :; else
@@ -46,6 +48,6 @@ AT_CHECK(["$abs_top_srcdir"/configure
lt_cv_prog_compiler_pic="$C_pic_flag" ]dnl
: ${MAKE=make}
AT_CHECK([$MAKE], [], [stdout], [ignore])
AT_CHECK([if ./libtool --features | grep 'enable shared libraries'; then ]dnl
- [ grep -e -fpic stdout; else exit 77; fi], [], [ignore], [ignore])
+ [ grep ' -fpic' stdout; else exit 77; fi], [], [ignore], [ignore])
AT_CLEANUP
- Re: proposed autobuild_mode naming scheme, (continued)
- Re: Next Libtool Point Release Pending, Bob Friesenhahn, 2010/08/09
- [PATCH] Autotest 2.62 bug?, Gary V. Vaughan, 2010/08/09
- Re: [PATCH] Autotest 2.62 bug?, Eric Blake, 2010/08/09
- [PATCH] Make testsuite compatible with Autoconf 2.62 again., Gary V. Vaughan, 2010/08/10
- Re: Next Libtool Point Release Pending, Bob Friesenhahn, 2010/08/06
- Re: [RFT PATCH v4 0/8] Sysroot series, Paolo Bonzini, 2010/08/03
Re: [RFT PATCH v4 0/8] Sysroot series, Charles Wilson, 2010/08/01
- fix pic_flag test (was: [RFT PATCH v4 0/8] Sysroot series),
Ralf Wildenhues <=
Re: [RFT PATCH v4 0/8] Sysroot series, Ralf Wildenhues, 2010/08/02
Re: [RFT PATCH v4 0/8] Sysroot series, Ralf Wildenhues, 2010/08/08