[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take

From: Charles Wilson
Subject: Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)
Date: Fri, 27 Aug 2010 17:22:55 -0400
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv: Gecko/20090812 Thunderbird/ Mnenhy/

On 8/27/2010 2:01 PM, Ralf Wildenhues wrote:
> * Charles Wilson wrote on Fri, Aug 27, 2010 at 06:35:31PM CEST:
>> Now, this is a little disturbing, since my -dlpreopen was supposed to
>> have fixed this;
> Would be good to fix, yes.  On *nix, I'd be suggesting git bisect now,
> no idea if you can stand the wait on w32 though.  At least you should be
> able to speed it up significantly with something like
>   make check TESTSUITEFLAGS=-V TESTS="all the mdemo ones"
> in the bisection script, and with some luck, such a script can run
> unsupervised ...
>> The real bug here is that the relink tests (both of them, actually)
>> should be skipped when cross-compiling, because you have no business
>> trying to execute the $host executable.
> I kind of agree.  Can we make it so that it is tested, but when the test
> programs don't behave as expected, and we cross-compile, we SKIP instead
> of FAIL?  Or is even trying to execute the broken programs a sin, in
> which case we should SKIP outright?  Thanks.

I think they should be SKIPPED always.

The test actually tries to arrange things so that the executable fails,
by hiding its dependent DLLs.  Well, on cross, we "fail" automatically
'cause we can't run the $host exe, so we PASS that part of the test --
but for the wrong reason.  And, because the output from the "failure" is
not what we expect...sometimes our "failure" results in a SKIP or a
FAIL.  And sometimes we ARE able to run the $host executable
(cygwin->mingw, linux->w32 with binfmt) and things just get really hairy.

It's just not reliable.  SKIP 'em.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]