[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symb
Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.
Sat, 28 Aug 2010 19:15:16 +0200
* Charles Wilson wrote on Sat, Aug 28, 2010 at 05:31:57PM CEST:
> On 8/28/2010 11:31 AM, Ralf Wildenhues wrote:
> > * Charles Wilson wrote on Sat, Aug 28, 2010 at 05:13:38PM CEST:
> >> On 8/28/2010 9:21 AM, Ralf Wildenhues wrote:
> >>> [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST
> >> I don't think __WINDOWS__ is the correct symbol; that is only defined by
> >> Watcom C/C++. I think this should be changed to _WIN32 throughout.
> > Oops. Like, this?
> Yes, that looks fine.
Great, thanks for the quick review, and also Vincent for the help!
> > Would it be sufficient if I tested this on a GNU/Linux -> MinGW cross?
> Yes; the mingw (gcc) compiler defines this symbol.
Done, works as well as it did before; pushed.