libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Extract the archive name from the .la file and use $AR (not ar).


From: Peter Rosin
Subject: Re: Extract the archive name from the .la file and use $AR (not ar).
Date: Tue, 31 Aug 2010 21:04:42 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2

Den 2010-08-31 19:30 skrev Ralf Wildenhues:
> * Peter Rosin wrote on Tue, Aug 31, 2010 at 07:21:34PM CEST:
>> Den 2010-08-31 19:11 skrev Ralf Wildenhues:
>>>   libtool --mode=link $CC ... -o libfoo.a baz.o libbar.a
>>>
>>> should be adding baz.o and all objects in libbar.a to libfoo.a, i.e., it
>>> should extract all objects from libbar.a Instead, libfoo.a is added *as
>>> single member* into libfoo.a.  That's the bug.
>>
>> (assuming typo and that you meant that libbar.a is added *as single member*)
> 
> Yes, sorry.
> 
>> In that case, MS lib does probably not see baz.o when it creates libfoo.a,
>> and the test could be made stricter by checking that baz.o is also part of
>> libfoo.a, since MS lib does the part that is currently tested for
>> (extracting libbar.a and putting the contents in libfoo.a).
> 
> Cool.  Yes, please extend the test.  If MS lib still passes, you can
> adjust the xfail line, something like
> 
>   # This test passes with MS lib.
>   AT_XFAIL_IF([case $AR in ar-lib\ *) false;; *) :;; esac])

It appears that the *as single member* part isn't true. So, after tightening
the test up, it still passes with MS lib. Pushing as attached...

Cheers,
Peter

Attachment: 0001-archive-in-archive.at-passes-with-Microsoft-lib.patch.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]