Re: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path.

[Ralf Wildenhues]

* Peter Rosin wrote on Wed, Sep 01, 2010 at 10:33:59PM CEST:
> From 16232cc7ddfc4bab981a2fa2d87757c68832b32e Mon Sep 17 00:00:00 2001
> From: Peter Rosin <address@hidden>
> Date: Sun, 29 Aug 2010 18:26:16 +0200
> Subject: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path.
> 
> * libltdl/config/ltmain.m4sh (func_mode_compile): Replace the
> fix_srcfile_path hook with a call to func_to_tool_file.
> * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS) [cygwin,mingw,pw32]
> [cegcc]: Drop fix_srcfile_path.

Please ask google codesearch whether fix_srcfile_path is used by third
party packages which expect it to be set inside the configure script.
In case of doubt, we should keep the setting of it for compat reasons.

The patch series is lacking libtool.texi updates.

The changes to archive_cmds that introduce func_to_tool_file will make
it impossible (right?) for users to use that command inside a configure
test.  I'm not sure whether that is a problem in practice -- we
recommend using LT_OUTPUT and then using ./libtool, but a quick
codesearch check shouldn't hurt.

1/7 has a superfluous commented-out line in ltmain.

I haven't looked at the patch series in detail yet, but 1-6 look fairly
reasonable otherwise.  7 looks risky because of the logic around there;
also, the nm @file test isn't a real feature test.  Also, I just noticed
that nm_file_list_spec isn't always initialized properly.

Cheers,
Ralf