libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [cygwin|mingw] Correct static lib symbol extraction failure.


From: Ralf Wildenhues
Subject: Re: [PATCH] [cygwin|mingw] Correct static lib symbol extraction failure.
Date: Sun, 12 Sep 2010 16:25:13 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

* Ralf Wildenhues wrote on Sun, Sep 12, 2010 at 04:20:13PM CEST:
> * Charles Wilson wrote on Sun, Sep 12, 2010 at 03:19:51PM CEST:
> > * libltdl/config/ltmain.m4sh (func_mode_link): When prefer_static_libs,
> > ensure old_library name is used as linklib when possible.

> Why does the patch have "[cygwin|mingw]" in the summary?  It changes a
> code path that is shared by most systems out there, no?  I'd rather see
> a 'Fixes foo on Cygwin and MinGW' in the details, so that when searching
> the summary log later, this patch isn't mistaken for a w32-only one.

Also, $linklib is used for several other things.  It would seem prudent
to make sure it is clear that this is a very intrusive patch, or use
another helper variable to make it less intrusive.

Cheers,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]