Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

[Peter Rosin]

Den 2010-09-16 19:25 skrev Ralf Wildenhues:
> Hi Peter,
> 
> * Peter Rosin wrote on Mon, Sep 13, 2010 at 10:03:10AM CEST:
>> Ok to push this time?
> 
> Okay.
> 
> I think it ought to be possible to clean up the logic a bit further, to
> make it easier to follow when you read the whole paragraph of code, but
> such a cleanup is just as good to make alongside the eval fixes, and
> early in the release cycle.
> 
> BTW, how about s/try_normal_branch/nm_tool_conversion_needed/ and swap
> yes and no?  Strictly optional, and only if you prefer that.

I was renaming that variable half a dozen times but never found a name
I was satisfied with. The problem with nm_tool_conversion_needed is
that it might be needed, but not working.

So, I'm pushing as is.

And thanks for the review! I should also add that with this patch in, it
is ok to make the release from my point of view.

Cheers,
Peter