libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on lib


From: Roumen Petrov
Subject: Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.
Date: Sat, 18 Sep 2010 01:04:45 +0300
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.11) Gecko/20100721 SeaMonkey/2.0.6

Hi Peter,

Peter Rosin wrote:
Hi!

need_lib_prefix.at currently fails with MSVC.

Hmm probably test fail as shared library is build without -no-undefined flag.

Did libtool MSC allow creation of shared libraries without -no-undefined ?

On windows platforms (msc, gcc(mingw*)) may be the test require some PATH magics.
(as example like func_fix_path from static.at test)


I think the test
is there to ensure that "weird" systems continue to work even
if the testsuite is running on a "normal" system. "weird" in
this case are systems with need_lib_prefix set to "unknown" and
"normal" are those with it set to "no". However, there are
even weirder systems where need_lib_prefix should perhaps be
set to "never" (i.e. MSVC) but that currently simply sets it
to "no". "never" would perhaps be more appropriate since preopen
doesn't work right if libs have a lib prefix.


I think OS/2 is
affected in the same way as MSVC, but I have no means to test
that.

The below patch makes the need_lib_prefix.at test skip for the
even weirder systems, i.e. those where libname_spec does not
prefix library names with lib.

The test use libtool -module flag and thus libtool won't complain if library is created without "lib" prefix.

Ok to push?

No if -no-undefined  and PATH magic resolve failure in this test.

[SNIP]


Roumen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]