libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: reloadable objects do not work on MSVC, SKIP test.


From: Peter Rosin
Subject: Re: [PATCH] tests: reloadable objects do not work on MSVC, SKIP test.
Date: Wed, 22 Sep 2010 10:30:07 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2

Den 2010-09-22 10:24 skrev Gary V. Vaughan:
> Hi Peter,
> 
> On 22 Sep 2010, at 15:15, Peter Rosin wrote:
>> Den 2010-09-22 10:11 skrev Gary V. Vaughan:
>>> Hi Peter,
>>>
>>> On 22 Sep 2010, at 15:02, Peter Rosin wrote:
>>>> This is fixing a testsuite issue for MSVC, and I don't need it
>>>> to go in before the release.  So, no rush.
>>>>
>>>> The patch was previously discussed here:
>>>> http://lists.gnu.org/archive/html/libtool-patches/2008-08/msg00051.html
>>>>
>>>> and it is on the pr-msvc-support branch as commit
>>>> fbc144008bd66848111fb8ef2d7293b33957ea1a (even though that commit
>>>> happened by mistake and was one of the very unpolished ones).
>>>>
>>>> Ok to push after the 2.4 release?  (or before if Gary is ok with that)
>>>>
>>>> (with this patch and the other one making need_lib_prefix.at skip,
>>>> there are no more fails for MSVC/MSYS. Boggle!)
>>>
>>> Sure, go ahead.  And please add a `no test failures with msvc/msys'
>>> entry to NEWS while you're there.
>>
>> I assume you mean that both patches are OK to push then?
> 
> Both patches?  I saw only the one attached to the mail I replied to.
> That one is fine to push, yes.  What's the other one?

The one I mentioned in the same sentence where I said no more fails, i.e
"the other one making need_lib_prefix.at skip".  See this thread:
http://lists.gnu.org/archive/html/libtool-patches/2010-09/msg00201.html

Hmm, but "no more fails" is a truth with modification.  The *new*
testsuite has no unexpected fails.  There are still a bunch of
needed __declspec(dllimport) in the old testsuite, and perhaps there
are some other fails as well.  Not sure actually, I'm not normally
running it.  Given that, I'll hold back on any bragging in NEWS...

Cheers,
Peter



reply via email to

[Prev in Thread] Current Thread [Next in Thread]