Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

[Ralf Wildenhues]

* Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 10:36:01PM CEST:
> On 23 Sep 2010, at 01:22, Ralf Wildenhues wrote:
> > * Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST:
> >> On 09/22/2010 12:13 PM, Ralf Wildenhues wrote:
> >>>> Is it acceptable instead to use a nested $(MAKE) invocation prior to
> >>>> running help2man to ensure the binary is up-to-date?
> >>> 
> >>> Can you show a patch so I can see what you mean?
> >> 
> >> $(srcdir)/doc/libtool.1: $(srcdir)/$(auxdir)/ltmain.sh
> >> +  $(MAKE) libtool
> >>    $(update_mans) --help-option=--help-all libtool
> > 
> > When -jN has been passed, the two makes may both try to update 'libtool'
> > at the same time, leading to a race.
> > 
> >> $(srcdir)/doc/libtoolize.1: $(srcdir)/libtoolize.in
> >> +  $(MAKE) libtoolize
> >>    $(update_mans) libtoolize
> > 
> > Likewise here.
> 
> How about a putting the shell code for libtoolize.in -> libtoolize
> transformation and writing:
> 
> $(srcdir)/doc/libtoolize.1: $(srcdir)/libtoolize.in
>       $(generate_libtoolize)
>       $(update_mans) libtoolize

That will not help, because 'make' may still run it in parallel with the
commands from the 'libtoolize' rule.

Cheers,
Ralf