[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/11] build: name temporary files in `Makefile.am' consis
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH v2 06/11] build: name temporary files in `Makefile.am' consistently. |
Date: |
Thu, 23 Sep 2010 20:46:27 +0200 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
Hi Gary,
this isn't a full review, I'm just adding a couple of hints that come to
mind at first glance.
* Gary V. Vaughan wrote on Thu, Sep 23, 2010 at 05:21:23PM CEST:
> This is another silly patch that ends up being mostly edited away
> by the next couple of patches in the series... but I think it's
> useful to split it out so that you can see what I'm thinking at
> each stage. It was also a good exercise because after splitting,
> I realised that the original 3/4 didn't apply this concept in all
> the places it could have.
>
> Okay to push?
Consistent naming seems like a good idea, however I'll note that while
8.3 file systems with cutoff policy allow to distinguish between
'libtoolize' and 'libtoolize.tmp', they don't do so for 'libtoolize'
and 'libtoolizeT'.
I normally wouldn't say we still need to really care about this much any
more, but we've had some DJGPP fixes in Autoconf and Automake a few
months ago due to bug reports.
Oh well, dunno if that's relevant.
> * Makefile.am (libltdl/m4/ltversion.m4): Rename temporary file
> to `ltversion.m4T'.
> (libltdl/config/ltmain.sh): Rename temporary file to `ltmain.shT'.
> (libtoolize): Rename temporary file to `libtoolizeT'.
> (tests/defs): Rename temporary file to `defsT'
> (tests/testsuite): Rename temporary file to `testsuiteT'.
> (CLEANFILES): Adjust and add `tests/defsT' and `tests/testsuiteT'.
Cheers,
Ralf
- Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call., (continued)
[PATCH v2 01/11] maint: rearrange Makefile.am in preparation for a follow-up patch., Gary V. Vaughan, 2010/09/23
[PATCH v2 02/11] maint: don't leak developer GREP, SED etc into distribution file., Gary V. Vaughan, 2010/09/23
[PATCH v2 03/11] build: compare `revision' rather than `correctver' in Makefile.am., Gary V. Vaughan, 2010/09/23
[PATCH v2 04/11] build: avoid unnecessary directory changes in Makefile rules., Gary V. Vaughan, 2010/09/23
[PATCH v2 05/11] build: factor Makefile.am `m4sh' invocations to LT_M4SH., Gary V. Vaughan, 2010/09/23
[PATCH v2 06/11] build: name temporary files in `Makefile.am' consistently., Gary V. Vaughan, 2010/09/23
- Re: [PATCH v2 06/11] build: name temporary files in `Makefile.am' consistently.,
Ralf Wildenhues <=
[PATCH v2 09/11] build: eliminate `ltmain.in' intermediate file., Gary V. Vaughan, 2010/09/23
[PATCH v2 08/11] build: don't hardcode repeated long paths in Makefile rules., Gary V. Vaughan, 2010/09/23
[PATCH v2 10/11] build: eliminate superfluous temporary files from `Makefile.am'., Gary V. Vaughan, 2010/09/23
[PATCH v2 11/11] maint: simplify and improve safety of bootstrap process., Gary V. Vaughan, 2010/09/23
[PATCH v2 07/11] build: make better use of automatic variables in `Makefile.am'., Gary V. Vaughan, 2010/09/23