[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: import variables for MSVC.

From: Roumen Petrov
Subject: Re: [PATCH] tests: import variables for MSVC.
Date: Sat, 25 Sep 2010 03:13:17 +0300
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100916 SeaMonkey/2.0.8

I sent my email before to finish, sorry.

Roumen Petrov wrote:
Ralf Wildenhues wrote:
* Peter Rosin wrote on Fri, Sep 24, 2010 at 02:44:25PM CEST:
I'll let Chuck and you hash out and decide all the details on this.

One question though: will all of these '#ifdef _MSC_VER' cases need
changing as soon as we add support for yet another w32 compiler? In
that case, I think the strategy should be reconsidered. The idea is
that the sources should ideally not need any, or at least not many,
changes in the future. Relying on compiler defines seems like a
suboptimal strategy, and should only be done if there is no other way.

I would like to propose different macros for export/import of variables
in format:

#define XXX(type) decorator_before type decorator_after

I sent my email before to finish, sorry.

Next in code to replace "int foo" with "XXX(int) foo".

About pre-processor flags - better is C code to start with #define BUIILD_FOO instead -DBUIILD_FOO in makefile.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]