[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: func_convert_file_cygwin_to_w32 woes
From: |
Ralf Wildenhues |
Subject: |
Re: func_convert_file_cygwin_to_w32 woes |
Date: |
Thu, 6 Jan 2011 21:29:47 +0100 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
[ dropping libtool@ ]
Hi Peter,
thanks for working on this!
* Peter Rosin wrote on Tue, Jan 04, 2011 at 05:44:58PM CET:
> Subject: [PATCH] Convert ranlib argument to toolchain format.
> --- a/libltdl/config/ltmain.m4sh
> +++ b/libltdl/config/ltmain.m4sh
> @@ -2412,6 +2412,8 @@ func_mode_install ()
>
> # Set up the ranlib parameters.
> oldlib="$destdir/$name"
> + func_to_tool_file "$oldlib" func_convert_file_msys_to_w32
> + tool_oldlib=$func_to_tool_file_result
Why does the $old_striplib command a few lines below this one not need
to use $tool_oldlib?
Dan, can you try 'make install-strip'?
> func_show_eval "$install_prog \$file \$oldlib" 'exit $?'
>
> @@ -8370,6 +8372,8 @@ EOF
> esac
> done
> fi
> + func_to_tool_file "$oldlib" func_convert_file_msys_to_w32
> + tool_oldlib=$func_to_tool_file_result
> eval cmds=\"$old_archive_cmds\"
>
> func_len " $cmds"
[...]
* Peter Rosin wrote on Wed, Jan 05, 2011 at 11:06:09AM CET:
> Den 2011-01-05 05:30 skrev Dan McMahill:
> > On 1/4/2011 11:44 AM, Peter Rosin wrote:
> >> Ok, I found a couple of minutes to look at this. Can you check if this
> >> patch helps?
> >>
> >> (It still needs a ChangeLog etc...)
The patch is OK with me if you fix the missing bits, and address the
above.
> Before I tie up the lose ends with this patch, I wonder if Ralf (or someone
> else) could tell me if I should also fix the other assignments of
> old_archive_cmds -- such as in the below snippet -- or is that completely
> irrelevant?
I wouldn't change them without being sure that the changes are
necessary.
Thanks,
Ralf