[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Stop "relink" searching host directory when installation prefix prov
Re: Stop "relink" searching host directory when installation prefix provided
Sun, 16 Jan 2011 18:13:58 +0100
* Martin Panter wrote on Sun, Jan 16, 2011 at 01:04:00PM CET:
> Don't search host directory during "relink" if $inst_prefix is provided
> --- libtool-2.4.orig/libltdl/config/ltmain.m4sh
> +++ libtool-2.4/libltdl/config/ltmain.m4sh
> @@ -6122,12 +6122,14 @@ func_mode_link ()
> # We cannot seem to hardcode it, guess we'll fake it.
> - add_dir="-L$libdir"
> - # Try looking first in the location we're being installed to.
> + # Default if $libdir is not relative to the prefix:
> + add_dir="-L$libdir"
> if test -n "$inst_prefix_dir"; then
> case $libdir in
> - func_append add_dir " -L$inst_prefix_dir$libdir"
> + add_dir="-L$inst_prefix_dir$libdir"
Wouldn't it also suffice to just prepend instead of append
-L$inst_prefix_dir$libdir? If no, why not?
Asking because I'm fairly sure not everybody uses DESTDIR for cross
compilation and assumes that the target directory is no-go land for
us. (I for one often do 'make install DESTDIR=/tmp/dest' merely to
tar up the installation tree to be scp'ed to another machine where
the NFS share is mounted rw.)
I haven't looked into this in detail yet, but thanks for the good
writeup and the many references. We need testsuite exposure for