[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 23/25] syntax-check: enable sc_program_name.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH 23/25] syntax-check: enable sc_program_name. |
Date: |
Wed, 16 Nov 2011 09:26:24 +0100 |
User-agent: |
KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) |
Hi Gary.
On Wednesday 16 November 2011, Gary V wrote:
> Hi Stefano,
>
> Thanks for the review.
>
> >>
> >> # GPL_version: checks for GPLv3, which we don't use
> >> -# program_name: libtool has no programs!
> >>
> > But then, since libtool doesn't offer any "real" program, what is
> > the point of enabling the `sc_program_name' check?
>
> Quite arguably, there is no point at the moment.
>
So at least I haven't misunderstood the scope/meaning of your change ...
Good for me, I was suspecting to be missing something obvious :-)
> But at some point
> we may grow a "real" program (ltmain.c has been on the horizon for
> many years), and letting syntax-check run everything it has if at all
> possible means we won't have to remember to go back and enable those
> additional NOP tests if that day ever arrives.
>
> If you object strongly, I can be persuaded to change my mind however.
>
I don't object *strongly*; it just seems confusing to me to add checks
for a feature/setup that is not yet implemented, nor is planned to be
implemented in the near future. I leave the decision of whether this
is worth worrying about to you.
Regards,
Stefano
- [PATCH 18/25] syntax-check: fix violations and re-enable sc_prohibit_undesirable_word_seq., (continued)
- [PATCH 18/25] syntax-check: fix violations and re-enable sc_prohibit_undesirable_word_seq., Gary V. Vaughan, 2011/11/15
- [PATCH 20/25] syntax-check: fix violations and re-enable sc_useless_cpp_parens., Gary V. Vaughan, 2011/11/15
- [PATCH 19/25] syntax-check: fix violations and re-enable sc_space_tab., Gary V. Vaughan, 2011/11/15
- [PATCH 22/25] syntax-check: enable sc_bindtextdomain., Gary V. Vaughan, 2011/11/15
- [PATCH 23/25] syntax-check: enable sc_program_name., Gary V. Vaughan, 2011/11/15
[PATCH 24/25] syntax-check: enable sc_prohibit_always_true_header_tests., Gary V. Vaughan, 2011/11/15
[PATCH 25/25] dist: hook syntax-check into `make distcheck'., Gary V. Vaughan, 2011/11/15
[PATCH 21/25] syntax-check: fix violations and implement sc_trailing_blank-non-rfc3676., Gary V. Vaughan, 2011/11/15