|
From: | Stefano Lattarini |
Subject: | Re: [PATCH 3/7] tests: migrate tests/sh.test checks to syntax-checks. |
Date: | Mon, 21 Nov 2011 20:52:34 +0100 |
User-agent: | KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) |
Hi Gary. Just a quick nit (I haven't looked at the whole series, and not even at the whole patch in fact; sorry). On Monday 21 November 2011, Gary V wrote: > for file > do > - test -f $file || touch $file > + test -f "$file" || touch $file > What's the point of quoting file after `test -f' it it remains unquoted after `touch'? Regards, Stefano
[Prev in Thread] | Current Thread | [Next in Thread] |