[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.
From: |
Eric Blake |
Subject: |
Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw. |
Date: |
Thu, 08 Dec 2011 05:56:39 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 12/08/2011 03:21 AM, Gary V. Vaughan wrote:
> The recently pushed series of patches included the controversial
> introduction of an additional 3 forks per invocation, which might
> add a minute or two of wall-clock time to giant builds on windows.
> By assuming that windows will run shell scripts on some shell with
> all the modern optional features that libtool wants, this patch
> eliminates even those 3 new forks.
>
> Okay to push?
I'm a bit reluctant to do this via a host check;
>
> +# Forks are unreasonably slow under Windows, so we assume that, for at
> +# least cygwin and mingw, /bin/sh is bash, and save at least 3 forks per
> +# invocation:
> +case $host in
> + *cygwin* | *mingw*)
Instead of doing it this way, I'd almost rather see:
if test "${BASH_VERSION+set}" = set; then
although if cygwin ever follows debian's lead of using dash for faster
/bin/sh, I'm not sure if there is a reliable forkless way to detect dash.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [PATCH] libtool: minimise forks per invocation on cygwin and mingw., Gary V. Vaughan, 2011/12/08
- Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.,
Eric Blake <=
- Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw., Stefano Lattarini, 2011/12/08
- Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw., Gary V. Vaughan, 2011/12/08
- FYI [PATCH] libtool: minimise forks per invocation under bash., Gary V. Vaughan, 2011/12/18
- Re: FYI [PATCH] libtool: minimise forks per invocation under bash., Stefano Lattarini, 2011/12/18
- Re: FYI [PATCH] libtool: minimise forks per invocation under bash., Stefano Lattarini, 2011/12/18
- Re: FYI [PATCH] libtool: minimise forks per invocation under bash., Gary V. Vaughan, 2011/12/18
- Re: FYI [PATCH] libtool: minimise forks per invocation under bash., Stefano Lattarini, 2011/12/18
- Re: FYI [PATCH] libtool: minimise forks per invocation under bash., Gary V. Vaughan, 2011/12/18