libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: git-version-gen w/o git


From: Peter Rosin
Subject: Re: git-version-gen w/o git
Date: Thu, 18 Oct 2012 15:09:38 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1

[dropping-gnulib for this part]

On 2012-10-18 15:02, Eric Blake wrote:
> [adding-gnulib]
> 
> On 10/18/2012 06:50 AM, Peter Rosin wrote:
>> @@ -128,8 +128,10 @@ $(ltversion_m4): $(ltversion_in) $(dotversion)
>>      done; \
>>      if $$rebuild; then \
>>        rm -f '$@'; \
>> -      if test -f '$(srcdir)/.serial'; then \
>> -        serial=`cat '$(srcdir)/.serial'`; \
>> +      if test -d '$(srcdir)/.git' && git --version >& /dev/null; then \
>> +        $(git_commit_count) > '$(srcdir)/.serial'; \
>> +      fi; \
>> +      serial=`cat '$(srcdir)/.serial'`; \
> 
> However, something like this would be useful in libtool.

That hunk was wrong, this is what I meant:

@@ -128,11 +128,10 @@ $(ltversion_m4): $(ltversion_in) $(dotversion)
        done; \
        if $$rebuild; then \
          rm -f '$@'; \
-         if test -f '$(srcdir)/.serial'; then \
-           serial=`cat '$(srcdir)/.serial'`; \
-         else \
-           serial=`$(git_commit_count)`; \
+         if test -d '$(srcdir)/.git' && git --version >& /dev/null; then \
+           $(git_commit_count) > '$(srcdir)/.serial'; \
          fi; \
+         serial=`cat '$(srcdir)/.serial'`; \
          if test 0 = '$(V)'; then echo "  GEN   " $@; \
          else echo $(bootstrap_edit) "'$(ltversion_in)' > '$@'"; fi; \
          $(bootstrap_edit) '$(ltversion_in)' > '$@'; \



>>        else \
>>          serial=`$(git_commit_count)`; \
>>        fi; \


Sorry for the noise.

Cheers,
Peter




reply via email to

[Prev in Thread] Current Thread [Next in Thread]