Re: [PATCH] Fix clang linking if flags contain '-mllvm $arg'.

[Brooks Moses]

On 12/25/2012 08:09 PM, Johannes Obermayr wrote:
> Fixes:
> http://llvm.org/bugs/show_bug.cgi?id=14716

The idea is right, but commented-out code is not the right way to explain 
this in a finished patch.

I confirmed with a local LLVM programmer that what's going on here is that 
-mllvm is for passing things through from Clang to LLVM -- and, since Clang 
never uses LLVM for linking, the -mllvm options are always irrelevant for 
linking.

(He also pointed out that anyone using -mllvm with libtool is probably doing 
it wrong anyway; -mllvm is meant as an escape hatch for experimental stuff 
that isn't yet reflected in the Clang front-end, and supported things like 
-mllvm -vectorize should be replaced by the equivalent Clang option.)

Thus, I've committed the attached revision of your patch, which explains in 
a short rewritten comment why the "mllvm" handler is empty.

Thanks!
- Brooks

0001-libtool-Discard-mllvm-arg-options-when-linking.patch
Description: Text Data