Re: [PATCH] OS/2 patches

[Gary V. Vaughan]

Hi KO,

Very sorry for the immense delay in getting to this.

> On Nov 4, 2014, at 6:12 AM, KO Myung-Hun <address@hidden> wrote:
> 
> Hi/2.
> 
> I've rebased to master.

Awesome, and thanks for persevering :)

> Review, please...
> 
> [PATCH 01/11] libtool: don't eliminate duplications in $postdeps and $predeps 
> on OS/2

no effect on systems other than *-os2*, applied

> [PATCH 02/11] libtool: support to link against static libraries on OS/2

same again, applied with minimal edits to pass `make syntax-check`

> [PATCH 03/11] ltdl: OS/2 uses other APIs to load a DLL than LoadLibrary() on 
> Windows

no effect on systems other than *-os2*, applied

> [PATCH 04/11] libtool: there is no need to relink DLLs on OS/2

same again, reworded commit message

> [PATCH 05/11] libtool: set lt_cv_deplibs_check_method to pass_all on OS/2

likewise

> [PATCH 06/11] libtool: support -Zxxx options used on OS/2

I have some concerns on letting all -Z options through, as this may affect other
compilers that I can't test, so I made -Z conditional on $host matching os2*.

> [PATCH 07/11] libtool: fix DLL creation/installation/uninstallation on OS/2

no effect an systems other than *-os2* again, applied with light edits to commit
message, comments and to fix failures with `make syntax-check`.

> [PATCH 08/11] libtool: add -os2dllname option

applied with some edits for English, and moving the NEWS entry to the correct
release

> [PATCH 09/11] libtool: support -export-symbols and -export-symbols-regex on 
> OS/2

no effect on systems other than *-os2*, applied with edits to pass `make 
syntax-check`

> [PATCH 10/11] libtool: support versioning on OS/2

likewise

> [PATCH 11/11] bootstrap: double quote an expression with a wildcard

imported to upstream bootstrap repo, and synchronised with libtool

Please check that everything still works for you as expected, as I don't have 
OS/2
to maintain the integrity of the OS/2 port.

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)