[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libtoolize.in: remove two umask 0
From: |
Gary V. Vaughan |
Subject: |
Re: [PATCH] libtoolize.in: remove two umask 0 |
Date: |
Fri, 28 Nov 2014 16:54:00 +0000 |
Hi Tijl,
Thanks for the patches. Applied already, and will be pushed as soon
as the test suite completes successfully.
Cheers,
--
Gary V. Vaughan (gary AT gnu DOT org)
> On Nov 27, 2014, at 5:59 PM, Tijl Coosemans <address@hidden> wrote:
>
> "libtoolize --ltdl -c" creates some files with write permissions for
> everybody because it sets "umask 0" in two places. This patch removes
> the umask commands.
>
> ---
> libtoolize.in | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/libtoolize.in b/libtoolize.in
> index d819470..530232d 100644
> --- a/libtoolize.in
> +++ b/libtoolize.in
> @@ -392,11 +392,7 @@ func_copy ()
>
> # Filters always take priority.
> if test -n "$my_filter"; then
> - if $opt_dry_run || {
> - ( umask 0
> - $SED -e "$my_filter" "$my_srcfile" > "$my_destfile"
> - ) >/dev/null 2>&1
> - }
> + if $opt_dry_run || $SED -e "$my_filter" "$my_srcfile" > "$my_destfile"
> 2>/dev/null
> then
> func_notquiet_once "$my_msg_var"
> if $opt_verbose; then
> @@ -422,11 +418,7 @@ func_copy ()
> my_copy_msg="$my_copy_type file '$my_destfile'"
> $opt_verbose && my_copy_msg="$my_copycmd $my_srcfile $my_destdir"
>
> - if $opt_dry_run || {
> - ( umask 0
> - $my_copycmd "$my_srcfile" "$my_destfile"
> - ) >/dev/null 2>&1
> - }
> + if $opt_dry_run || $my_copycmd "$my_srcfile" "$my_destfile" >/dev/null
> 2>&1
> then
> func_notquiet_hdr "$my_msg_var" "$my_copy_msg"
> else
> --
> 2.1.0
>
>