Re: [patch #8675] elftoolchain strip support

[Pavel Raiskup]

On Friday 27 of November 2015 02:50:27 Ed Maste wrote:
> On 20 September 2015 at 12:12, Ed Maste <address@hidden> wrote:
> > On 27 May 2015 at 13:59, Ed Maste <address@hidden> wrote:
> >>> Currently libtool does not properly detect elftoolchain's version of 
> >>> strip(1).
> >>> The proposed patch fixes this.
> >>
> >> For reference, this issue has been discussed in FreeBSD at
> >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198611
> >>
> >> It's possible to simplify the test a little bit; $EGREP is already
> >> used in libtool.m4. This is what I had:
> >>
> >> --- a/m4/libtool.m4
> >> +++ b/m4/libtool.m4
> >> @@ -2207,7 +2207,8 @@ m4_defun([_LT_CMD_STRIPLIB],
> >>  striplib=
> >>  old_striplib=
> >>  AC_MSG_CHECKING([whether stripping libraries is possible])
> >> -if test -n "$STRIP" && $STRIP -V 2>&1 | $GREP "GNU strip" >/dev/null; then
> >> +if test -n "$STRIP" && $STRIP -V 2>&1 |
> >> +  $EGREP "GNU strip|strip.*elftoolchain" >/dev/null; then
> >>    test -z "$old_striplib" && old_striplib="$STRIP --strip-debug"
> >>    test -z "$striplib" && striplib="$STRIP --strip-unneeded"
> >>    AC_MSG_RESULT([yes])
> >
> > Following up again to see about including this patch in libtool. Is
> > there anything else I can do to have this considered?
> 
> Ping?

Xin Li and Ed, thanks and sorry for the delay.  Can you please check the
attached patch on FreeBSD?  There is separate code fork for
freebsd/elftoolchain so we could possibly use different options than the
defaults which are used with GNU strip.

Pavel

0001-m4-libtool.m4-FreeBSD-elftoolchain-strip-support.patch
Description: Text Data