Re: The case of libkmod's .so versioning attempts, and induced collisions

[Jan Engelhardt]

On Wednesday 2012-02-08 03:45, Peter O'Gorman wrote:

> On 02/07/2012 07:06 PM, Lucas De Marchi wrote:
>>
>> Yes. We can always learn. It seems that this is not the case here.
>> There are other projects releasing like this and no one pointed out to
>> a reasonable argument against it. That means these arguments are not
>> valid in our case:
>
> Again, use -version-number a:b:c to get libfoo.so.a.b.c instead of screwing
> around with the calculations yourself and using -version-info.
>
> This flag is available since libtool-1.5.x and was added by the 
> freedesktop.org
> folks, iirc, to retain version number information when they moved to the
> autotools.
>
> Using this flag should satisfy all involved.


---8<---

Change the kmod Makefile from using -version-info to -version-number
to make it clear that the kmod project is not trying to subvert the
libtool "interface" number concept, but in fact does not do
libtool-style counting.

---
 Makefile.am |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Index: kmod-5/Makefile.am
===================================================================
--- kmod-5.orig/Makefile.am
+++ kmod-5/Makefile.am
@@ -39,9 +39,8 @@ SED_PROCESS = \
 %.pc: %.pc.in Makefile
        $(SED_PROCESS)
 
-LIBKMOD_CURRENT=2
-LIBKMOD_REVISION=0
-LIBKMOD_AGE=0
+LIBKMOD_SO_MAJOR=2
+LIBKMOD_SO_MINOR=0
 
 noinst_LTLIBRARIES = libkmod/libkmod-util.la
 libkmod_libkmod_util_la_SOURCES = libkmod/libkmod-hash.c \
@@ -71,7 +70,7 @@ EXTRA_DIST += libkmod/libkmod.sym
 EXTRA_DIST += libkmod/COPYING libkmod/README
 
 libkmod_libkmod_la_LDFLAGS = $(AM_LDFLAGS) \
-       -version-info $(LIBKMOD_CURRENT):$(LIBKMOD_REVISION):$(LIBKMOD_AGE) \
+       -version-number ${LIBKMOD_SO_MAJOR}:${LIBKMOD_SO_MINOR} \
        -Wl,--version-script=$(top_srcdir)/libkmod/libkmod.sym
 libkmod_libkmod_la_DEPENDENCIES = libkmod/libkmod-util.la \
                                  ${top_srcdir}/libkmod/libkmod.sym