[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [PATCH 5/7] build: make libunwind-coredump build o
From: |
Tommi Rantala |
Subject: |
Re: [Libunwind-devel] [PATCH 5/7] build: make libunwind-coredump build optional |
Date: |
Wed, 5 Sep 2012 11:48:24 +0300 |
2012/9/4 Cody P Schafer <address@hidden>:
> Disable the building of libunwind-coredump except on x86_64 and x86
> (where implimentations exsist).
Technically checking just the architecture would not be enough, since
there are also some OS specific bits and pieces.
We could also provide no-op implementations for the missing
architectures, similar to (as far as I can tell) the setjmp library.
This might make distro people happier, as they could package the
coredump library for all architectures unconditionally.
> +no_force_coredump=true
> +AC_ARG_ENABLE(coredump,
> + AS_HELP_STRING([--enable-coredump],[build libunwind-coredump
> library]),
> + [no_force_coredump=false; use_coredump=true],
> + [no_force_coredump=false; use_coredump=false])
> +
> +if $no_force_coredump; then
> + case "$host_arch" in
> + x86|x86_64) use_coredump=true ;;
> + *) use_coredump=false;;
> + esac
> +fi
BTW, after applying this patch, the coredump library is no longer
built by default on my x86_64 machine. I believe that AC_ARG_ENABLE()
is not used entirely correctly here.
BR,
Tommi
- [Libunwind-devel] [PATCH 0/7] Fixup the PowerPC (64 & 32 bit) builds., Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 2/7] ppc32: remove unused dmy_vrregset, Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 3/7] ppc32: add used attribute to dmy_ctxt, Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 4/7] ppc32: ppc64: test altivec support by running the compiler., Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 5/7] build: make libunwind-coredump build optional, Cody P Schafer, 2012/09/04
- Re: [Libunwind-devel] [PATCH 5/7] build: make libunwind-coredump build optional,
Tommi Rantala <=
- [Libunwind-devel] [PATCH 1/7] ppc32: ppc64: use AC_COMPILE_IFELSE to test __powerpc64__ macro for ppc64, Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 7/7] ppc64: remove compile warnings from wchar test., Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 6/7] configure: use AC_HELP_STRING for configure args instead of manual formating, Cody P Schafer, 2012/09/04