Re: [Lilypond-auto] Issue 3330 in lilypond: bracketify-stencil moves grob's refpoint

[lilypond]

Updates:
        Status: Fixed
        Labels: -Patch-countdown Fixed_2_17_19

Comment #73 on issue 3330 by address@hidden: bracketify-stencil moves grob's  
refpoint
http://code.google.com/p/lilypond/issues/detail?id=3330

Ok, after doing convert-ly work on \vspace (which I am not really proud  
of), this is in a state reasonable for pushing in order to give it  
exposure.  The last difference list for bitmap differences was
chord-names-languages.png: 48 differences
chord-slash-separator.png: 126 differences
footnote-auto-numbering-page-reset-page1.png: 574 differences
footnote-auto-numbering-page-reset-page2.png: 11329 differences
footnote-auto-numbering-page1.png: 576 differences
footnote-auto-numbering-page2.png: 11406 differences
footnote-auto-numbering-vertical-order-page1.png: 11445 differences
footnote-auto-numbering-vertical-order-page2.png: 1089 differences
footnote-break-visibility-page1.png: 456 differences
footnote-break-visibility-page2.png: 456 differences
footnote-break-visibility-page3.png: 456 differences
footnote-footer-padding.png: 1738 differences
footnote-page1.png: 678 differences
footnote-page2.png: 4276 differences
footnote-spanner-page1.png: 1158 differences
footnote-spanner-page2.png: 18099 differences
fret-diagrams-size.png: 4153 differences
in-note-page1.png: 29518 differences
in-note-page2.png: 26704 differences
instrument-name-markup.png: 120 differences
markup-arrows.png: 246 differences
markup-braces.png: 156 differences
markup-lines-page1.png: 692 differences
markup-lines-page2.png: 92 differences
markup-music-glyph.png: 49 differences
markup-note.png: 2290 differences
markup-scheme.png: 10110 differences
markup-syntax.png: 3834 differences
page-headers-and-footers-page1.png: 26702 differences
page-headers-and-footers-page2.png: 20593 differences
page-headers-and-footers-page3.png: 19683 differences
parenthesize-markup.png: 855 differences
pdfmark-metadata.png: 493 differences
predefined-fretboards.png: 48 differences
test-output-distance.png: 4160 differences
35 differences found.

All of the remaining differences have explainable reasons.  chord-* and  
instrument-name-markup will need further tweaking in order to have strings  
using \flat look nice.  But that tweaking is an isolated result of a  
desired change in semantics and is something that can be done disconnected  
from the rest of the changes.

Pushed to staging as
*   commit 8a1caa214f1d2b517a418fc59fa82a0f3bbe0f19
|\  Merge: 12e1a76 1fb4227
| | Author: David Kastrup <address@hidden>
| | Date:   Sun May 26 02:35:05 2013 +0200
| |
| |     Merge branch 'issue3330'
| |
| |     This merges a number of outstanding changes for
| |
| |     Issue 3330: bracketify-stencil moves grob's refpoint
| |
| |     comprising a rewrite of horizontal/vertical spacing.
| |
| * commit 1fb4227e7ca3d68dd4a775ff3f5095d8f4aa9d72
| | Author: David Kastrup <address@hidden>
| | Date:   Sun May 26 00:59:18 2013 +0200
| |
| |     Run scripts/auxiliar/update-with-convert-ly.sh
| |
| * commit 7ede19c76ff88110e1af1975e33bc0041680a0b5
| | Author: David Kastrup <address@hidden>
| | Date:   Sat May 25 13:06:06 2013 +0200
| |
| |     Add convert-ly rule increasing \vspace inside of \column
| |
| * commit fb98865011921ef7da172a0a59513f6b5367eacd
| | Author: David Kastrup <address@hidden>
| | Date:   Fri May 24 17:39:44 2013 +0200
| |
| |     Adapt input/regression/page-headers-and-footers.ly to empty lines  
being empty
| |
| * commit 4b1f3e392230dfd31312e192afb02deaf0ad77d0
| | Author: David Kastrup <address@hidden>
| | Date:   Wed May 15 23:20:47 2013 +0200
| |
| |     Don't remove "empty" stencils in several situations
| |
| |     Removing empty stencils was previously necessary to avoid spurious
| |     spacing in several circumstances that are properly catered for  
already
| |     by issue 3330.  Consequently, removing those special cases is now
| |     feasible and leads to more consistent results.
| |
| * commit 2ac8e9aebacf7ffab6bee799fcb345ae4bc28ecf
| | Author: David Kastrup <address@hidden>
| | Date:   Sun May 12 21:26:26 2013 +0200
| |
| |     Change spacing of chord flats to correspond to state before issue  
3330
| |
| * commit f8d1e7a4ed8efaf916ee556af7d6e18de24eca4d
| | Author: David Kastrup <address@hidden>
| | Date:   Thu May 2 20:39:00 2013 +0200
| |
| |     Rewrite wordwrap-stencils to deal nicely with X/Y-empty spacing
| |
| * commit 63b55150a23552c962531436fb239f4383d675b3
| | Author: David Kastrup <address@hidden>
| | Date:   Thu May 2 18:27:50 2013 +0200
| |
| |     Remove manual spacing of fret diagrams in  
input/regression/fret-diagrams-size.ly
| |
| |     After issue 3300, stencils with negative left extent get properly  
spaced
| |     in a line.
| |
| * commit 72cff9482b5681247ed0c7f1ddca160fda3d812d
| | Author: David Kastrup <address@hidden>
| | Date:   Wed Apr 24 13:07:55 2013 +0200
| |
| |     Issue 3330: bracketify-stencil moves grob's refpoint
| |
| |     Also fixes parenthesize-stencil.
| |
| * commit f31147964619f6e21eda04fa5dc38cfbdccd6ac9
| | Author: David Kastrup <address@hidden>
| | Date:   Sun Apr 28 07:20:37 2013 +0200
| |
| |     Keep buildings which are empty in either axis out of skylines
| |
| * commit 6ac913499ad626ae399a2a24c528659688a92fbe
| | Author: David Kastrup <address@hidden>
| | Date:   Sat Apr 27 15:01:18 2013 +0200
| |
| |     Let \hspace and \vspace use Y-empty and X-empty spacing,  
respectively
| |
| * commit a2995707ec4d3225c8aa6b6dbbce582aabab1b7a
| | Author: David Kastrup <address@hidden>
| | Date:   Sat Apr 27 14:59:48 2013 +0200
| |
| |     implement stack-stencil-line in terms of stack-stencils
| |
| * commit 56533b5364a0b52502387b2f899a3a58ed0eeba2
| | Author: David Kastrup <address@hidden>
| | Date:   Sun Apr 28 14:47:42 2013 +0200
| |
| |     simplify stack-stencils and rewrite stack-stencils-padding-list
| |
| * commit 35d5f2e2ff40e0bd35cf00f22c2428eac354e566
| | Author: David Kastrup <address@hidden>
| | Date:   Sat Apr 27 18:31:01 2013 +0200
| |
| |     Let stack-lines deal properly with vertical spacing (X-empty  
stencils)
| |
| * commit 15066d8beec430ab889fef51e5cdeeb9eeee83c2
| | Author: David Kastrup <address@hidden>
| | Date:   Sun Apr 28 12:53:58 2013 +0200
| |
| |     Let Stencil::align_to abort only if the stencil is empty in the  
alignment axis
| |
| |     Previously, the emptiness check was not axis specific.
| |
| * commit 7cb16a272217fa147b6f130ef7c467288ad208bf
| | Author: David Kastrup <address@hidden>
| | Date:   Fri May 10 11:48:21 2013 +0200
| |
| |     Add Stencil::stack function and ly:stencil-stack
| |
| |     This is the base for line-forming and stacking functions.  As  
opposed
| |     to Stencil::add_at_edge (which is better suited for creating  
combined
| |     glyphs), the metrics facilitate progress along a line.
| |
| * commit f66a2409fca6c7c4dab1f3fb03c2569648a9199b
| | Author: David Kastrup <address@hidden>
| | Date:   Sat Apr 27 21:13:29 2013 +0200
| |
| |     Rewrite Stencil::add_at_edge to treat "spacing" stencils differently
| |
| |     A spacing stencil is one that is non-empty in its own axis, but  
empty
| |     in the orthogonal axis.  Since they don't actually have a bounding  
box
| |     to convey, they don't need padding, and they don't suffer from the
| |     equality of the lower left bounding box corner with the reference
| |     point.
| |
| * commit a84bcfd8f40c4f7c1666534336f3f794ac763387
| | Author: David Kastrup <address@hidden>
| | Date:   Sat Apr 27 14:58:17 2013 +0200
| |
| |     Use (+inf . -inf) consistently for empty stencil intervals
| |
| * commit e30a837e32061005cc4a8d620be594938537a82b
| | Author: David Kastrup <address@hidden>
| | Date:   Thu May 23 22:03:10 2013 +0200
| |
| |     Don't admit purely horizontal spacing into the page layout
| |
| |     Its extents confuse the spacing engine.
| |
| * commit 9ec8fec284c7bc03390aa14589a94846196f9e04
| | Author: David Kastrup <address@hidden>
| | Date:   Sat Apr 27 21:12:30 2013 +0200
| |
| |     Let Box::translate ignore empty axes
| |
| * commit ea894e07caea124b2480413007ee23972b2f53ee
| | Author: David Kastrup <address@hidden>
| | Date:   Sat Apr 27 14:45:11 2013 +0200
| |
| |     Give ly:stencil-empty? an optional axis argument
| |
| * commit 2ed10dbb94e5ef13b6b781397730c9158e628350
| | Author: David Kastrup <address@hidden>
| | Date:   Sun Apr 28 13:07:28 2013 +0200
| |
| |     Create Stencil::is_empty (Axis)
| |
| * commit a8ac663bf03c250ea84bc499437ffc8d529fc047
| | Author: David Kastrup <address@hidden>
| | Date:   Sat Apr 27 14:43:40 2013 +0200
| |
| |     Let Stencil::is_empty use Box::is_empty
| |
| |     This is a change in semantics as an axis interval of '(1 . -1) is
| |     considered empty as an interval, while it is not sufficient for  
making
| |     a box axis empty.  Things like backspaces would have similar metrics
| |     and are different from no information at all.
| |
| * commit 0b9c108e213a6caeb4b40e1306b18700ae608fd4
| | Author: David Kastrup <address@hidden>
| | Date:   Sat Apr 27 14:39:34 2013 +0200
| |
| |     Make Box::is_empty more selective and create an axis-specific  
variant
| |
| |     Boxes are not really "empty" just because they show negative
| |     advancement on some axis.  A box is empty if its original dimensions
| |     of (+inf . -inf) are still unchanged for both axes.  And boxes can
| |     make an impact in one axis but not another (pretty much the  
definition
| |     of spacing), so is_empty can take an axis as argument now.
| |
| * commit 1a4ee6dc75714f53e4723552390dfec8f0ad7d04
| | Author: David Kastrup <address@hidden>
| | Date:   Thu May 2 17:29:16 2013 +0200
| |
| |     Use \null instead of \hspace for an empty line in tocTitleMarkup
| |
| * commit 07f40b1ebf0da248b425890146c5a91f57bb3e68
| | Author: David Kastrup <address@hidden>
| | Date:   Tue Apr 30 18:37:17 2013 +0200
| |
| |     Stop quite weird positioning for dots
| |
| |     Some code here used a translation on dots that should never have had
| |     an effect but causes problems in relation to the issue 3330 fix.
| |
| * commit 6a76e0d8b213b7174abe45a25eda1105bb2ee02e
|/  Author: David Kastrup <address@hidden>
|   Date:   Wed May 22 16:52:44 2013 +0200
|
|       Let Stencil::translate optimize the case of a null stencil  
expression
|


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings