[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5220 Let repe

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5220 Let repeatTie work inside of event-chord

Date:

Sun, 22 Oct 2017 11:41:59 +0000

Sometimes I think ist's absolutely pointless for me to run the regtests locally ...

Well I am not sure how you run the reg tests locally, but I don't do anything special. It could be that you are missing the 'make clean' in between the make check and the application of the patch/re-make that is not showing you a correct test-result.

This is the basic process I use (assuming the autogen.sh and configure has already run)

make -j3 CPU_COUNT=3
make -j3 CPU_COUNT=3 test-baseline
git apply --index ~/Desktop/issuexxx.diff (I download raw diffs from Rietveld directly rather than apply git formatted patches)
make clean
make -j3 CPU_COUNT=3
make -j3 CPU_COUNT=3 check
firefox ./out/test-results/index.html

I then add a make doc for completeness but obviously a make doc is not needed to run the reg tests.

I seem to recall that if I didn't do the make clean at this point it would give an unreliable patch test result - I cannot remember what it was without looking back, but I seem to recall it was to do with changed cc files.

I think I'll remove myself as the owner. Should I set it to abandoned?

Yes please.

[issues:#5220] Let repeatTie work inside of event-chord

Status: Started
Created: Sat Oct 21, 2017 04:11 PM UTC by Thomas Morley
Last Updated: Sun Oct 22, 2017 10:53 AM UTC
Owner: Thomas Morley
Attachments:

repeatTie-with-patch.png (16.3 kB; image/png)
repeatTie-without-patch.png (15.7 kB; image/png)

Let repeatTie work inside of event-chord

The previous coding of repeat-tie-engraver.cc is replaced by the
renamed coding of the laissez-vibrer-engraver.

http://codereview.appspot.com/335910043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot