[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5224 Update EventChord to include a ChordSemantics event entry which captures input semantic information from chord mode and uses it to create chord names.

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• Description has changed:

Diff:

• Needs: -->
• Patch: new --> needs_work
• Comment:

Charles,

I don't understand the reason for the dozens of files that are changed in your patch. Why you also have added a 'README.md' file (we don't tend to do that), the documentation files that have changed seem to contain diffs that have nothing at all to do with the description of your patch at all.

I wonder if you have made a mistake here and not rebased your changes against current master or are basing it off some other branch?

I cannot test the patch as it is at the moment. Sorry.

Please check.

---

[issues:#5224] Update EventChord to include a ChordSemantics event entry which captures input semantic information from chord mode and uses it to create chord names.

Status: Started
Created: Wed Nov 01, 2017 02:07 AM UTC by Charles Winston
Last Updated: Wed Nov 01, 2017 02:07 AM UTC
Owner: Charles Winston

Update EventChord to include a ChordSemantics event entry which captures input semantic information from chord mode and uses it to create chord names.

Without these semantics, naming chords based only on their notes results in ambiguous naming:
Example: Cm7 no root and Eb both have the exact same notes, and so there is no way to differentiate between them, unless we capture the data from chord mode: { cm:7.1 } as opposed to { eb }

http://codereview.appspot.com/332090043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto