[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5307 Skyl

From: Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5307 Skyline Refinements (Rounded Boxes and Rotated Ellipses)
Date: Sun, 15 Apr 2018 22:34:43 -0000

Hi David,

I'm not rotating any skylines.
It's just a problem of quantisation, i.e. intermediate points:

Basically, the number of points for drawing the ellipse is calculated from the circumference by scaling the radii, but currently, we just multiply the x-radius by the trans.xx value etc.. This does not work anymore as soon as there is any rotation involved, because this is nothing but the projection on the x-axis.
In a 90° rotation, currently the radii collapse to length 0, so does the circumference of the ellipse and we get 0 quantisation points and, consequently, the skyline collapes.

When using the full transformation matrix (i.e. yx and xy values as well) for calculating the lenth of the transformed radii, everything will work fine.

All the best,

[issues:#5307] Skyline Refinements (Rounded Boxes and Rotated Ellipses)

Status: Started
Labels: re
Created: Sun Apr 15, 2018 09:46 PM UTC by Torsten Hämmerle
Last Updated: Sun Apr 15, 2018 10:23 PM UTC
Owner: Torsten Hämmerle

Recently, there have been some discussions about mysterious spacing of \rounded-box markup.

Harm identified skyline problems as the cause and submitted the following bug report:
Possible regression with box-markup/rounded-box-markup
Before Mike Solomon's new skyline handling, there were no such uninteded extra margins.

Rounded Box Skylines

The skyline of boxes with rounded corners do not tightly wrap the boxes but there's an unintentional margin (as wide as the corner radius).

Apart from that here are a few other shortcomings and so I have decided to create a more general box-and-rotated-ellipses skyline issue.

Other issues

When working on this case, I came across a few other things that call for improvement and so I've included them into the test file. Most notably, there is a general problem with rotation. And it would be nice to recreate the rounded corners for large boxes/radii.
At the same time, one should keep run-of-the-mill stuff like ledger lines as simple and fast as possible.

Test file

A file with 'debug-skylines switched on and TextScript padding values set to 0 in order to be able to check how the markup objects are fitted together.
I have tried to demonstrate about everything you cold do with boxes (including scaling, rotating, cominations thereof).

#(ly:set-option 'debug-skylines #t)

  \set Staff.instrumentName = \markup #(lilypond-version)
  \override Staff.TextScript.padding = 0
  \override Staff.TextScript.outside-staff-padding = 0
  \override Staff.TextScript.outside-staff-horizontal-padding = 0
  \override Staff.TextScript.self-alignment-X = #CENTER
  \override Staff.TextScript.layer = 0
  c'' ^\markup \override #'(thickness . 4) \box \teeny 1
      _\markup \with-color #grey \filled-box #'(-1 . 4) #'(1 . 4) #1
  b'  ^\markup \rounded-box "2!" ^\markup \rounded-box "3"
  d'' ^\markup \circle "*" ^\markup \rotate #90 \ellipse "Elli"
      _\markup \with-color #grey \rotate #10 \filled-box #'(-2 . 5) #'(1 . 4) #10
      _ \markup \rotate #36 \override #'(corner-radius . 20) \scale #'(1 . 0.4)
                \rotate #-68 \scale #'(1.6 . 1) \rounded-box "dop"
  f'' _\markup \override #'(corner-radius . 0.5) \rounded-box "."
  a'  ^\markup \rotate #30 \rounded-box "rotated a"
      _\markup \scale #'(1 . 1.5) \rotate #45 \override #'(thickness . 5)
               \rounded-box \rotate #-45 \scale #'(2 . 1) \bold "!"
  d'' _\markup \override #'(corner-radius . 20) \rounded-box "4"
  a'' ^\markup \rotate #-165 \box "rotated b"
      _\markup \rotate #180 \override #'(corner-radius . 20) \rounded-box \teeny
               \override #'(baseline-skip . 0) \center-column { "Upside" "Down" }

(see attached PNG file)

Sent from because address@hidden is subscribed to

To unsubscribe from further messages, a project admin can change settings at Or, if this is a mailing list, you can unsubscribe from the mailing list.

Check out the vibrant tech community on one of the world's most
engaging tech sites,!
Testlilyissues-auto mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]