[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5319 Make skylines reflect grob rotation

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

OK, thanks, fair enough, that's why it asked.
Set to "Fixed_2_21_0".

---

[issues:#5319] Make skylines reflect grob rotation

Status: Fixed
Labels: Fixed_2_21_0
Created: Thu May 03, 2018 11:44 AM UTC by Torsten Hämmerle
Last Updated: Sat May 12, 2018 12:55 PM UTC
Owner: Torsten Hämmerle
Attachments:

• skyline-grob-rotation.png (59.4 kB; image/png)

http://codereview.appspot.com/342060043

As has been agreed in thread http://lilypond.1069038.n5.nabble.com/Skylines-and-certain-grob-properties-rotation-extra-offset-tt212002.html, skylines should reflect the grobs' "rotation" property.

The "rotation" property (grob-interface) will be applied to the stencil after skylines have been built. Therefore, the skylines currently do not know about grob rotation and stoically stay in place.

In the example PNG file, you can see the original skylines on the left compared to the enhanced skylines on the right:

• Hairpins now actually get "out of the way" when being rotated (vertical skylines)
• Note the distance of the hairpin to the stave: padding is respected due to more realistic skylines.
• TextScripts now align as they should
• Accidentals: The two sharps now will be placed directly above and below one another because they take up less vertical space when rotated (horizontal skylines)

All the best,
Torsten

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto