lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5349 Constnes


From: Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5349 Constness of Grob methods
Date: Wed, 20 Jun 2018 00:20:21 -0000

Diff:

--- old
+++ new
@@ -1,3 +1 @@
-Use more const Grobs in the Paper_column interface
-
-http://codereview.appspot.com/346100043
+Grob::internal_get_property is advertised as a const method, but it came up in a [code review](http://codereview.appspot.com/346100043) that "caching of values is not really conceptually const."  So, at the very least, the const is misleading.  It would be good to change it for clarity, but it might require a chain of consequential changes.

[issues:#5349] Constness of Grob methods

Status: Shelved
Created: Mon Jun 18, 2018 11:56 PM UTC by Dan Eble
Last Updated: Tue Jun 19, 2018 12:27 PM UTC
Owner: Dan Eble

Grob::internal_get_property is advertised as a const method, but it came up in a code review that "caching of values is not really conceptually const." So, at the very least, the const is misleading. It would be good to change it for clarity, but it might require a chain of consequential changes.


Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

reply via email to

[Prev in Thread] Current Thread [Next in Thread]