[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5251 document restNumberThreshold

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

I thought I asked not to run makelsr?

Yes, you did. But harm asked me to do so so that he could review. To make everyone happy I made those two patch sets.

I am going to test patch version 2 not 3 (without the makelsr).

That was what I intended. I’m sorry that I didn’t mention that.

Please don't commit the patch (when it eventually goes through) with makelsr included as it makes it inconvenient if we have to revert anything or cherry pick the real fix (because the makelesr is effectively merged into the real patch).

I won’t commit the makelsr run in the same commit as the other changes. I thought of something like

1st commit: Issue 5251/1: set default restNumberThreshold and fix a bug
2nd commit: Issue 5251/2: add snippet to NR (not the snippet file itself but only the change to rhythms.itely)
3rd commit: Issue 5251/3: add regtest
4th commit: Issue 5251/4: run makelsr

Would that be ok? Or should I leave out the makelsr run completely? Then the NR won’t build correctly, will it?

So ... if patch version 3 contains anything other than the just makelsr output you will need to re-submit again.

It doesn’t contain anything else.

---

[issues:#5251] document restNumberThreshold

Status: Started
Created: Tue Jan 09, 2018 07:58 PM UTC by Malte Meyn
Last Updated: Fri Dec 28, 2018 11:18 AM UTC
Owner: Malte Meyn
Attachments:

• restNumberThreshold.png (2.7 kB; image/png)

As it’s fairly common, recommended by Gould, and—depending on house style for longer measures—sometimes necessary to have single measure MMRs marked with a “1” in orchestral parts, it should be documented how this can be achieved:

\set restNumberThreshold = 0

The default seems to be “unset” but in multi-measure-rest-engraver.cc it is hardcoded to 1; you won’t find this value in engraver-init.ly.

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto