lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: breaking cleanups


From: Joe Neeman
Subject: Re: breaking cleanups
Date: Sat, 09 Sep 2006 09:53:26 +1000

This patch cleans up the engraver part of page-turning. I got rid of all
the clutter in paper-column-engraver in favour of doing things in
page-turn-engraver.

The main change algorithmically is that I defer everything until the
finalize() step. That is, during interpretation I just build up lists of
potential breaks, manual breaks and volta repeats. It probably makes
things a tiny bit faster since the algorithm for revoking turns during
repeats is now linear. More importantly, it solves a problem where the
old engraver would override manual turns.

Here's the ChangeLog, and I promise I will remember the patch...

2006-09-09  Joe Neeman  <address@hidden>

        * scm/define-context-properties.scm
        (all-internal-translation-properties): remove properties that
        were used to communicate page-turn stuff to the paper-column
        engraver.

        * lily/lily-guile.cc (robust_scm2string): new function

        * lily/paper-column-engraver.cc: Clean up page turn stuff

        * lily/page-turn-engraver.cc: Re-write the page turn logic here
        instead of cluttering up paper-column-engraver.cc

Attachment: page_turn_engraver.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]