Re: [PATCH] Chromatic staff

[Han-Wen Nienhuys]

Kevin Dalley escreveu:
> This patch is to be applied to the head.  It's a simple patch than my
> previous try.  Regression test included.
> 
> This patch allows the vertical position of each note
> to be set with a scheme function.
> This feature can be used for creating a chromatic staff, for example.

some comments:

>        SCM c0 = get_property ("middleCPosition");
> -      if (scm_is_number (c0))
> -     pos += scm_to_int (c0);
> +      int pos;
> +      if (pit == 0){
> +     pos = 0;
> +      }
> +      else if (ly_is_procedure (layout_proc)){
> +     SCM pitch = ev->get_property("pitch");
> +     pos = scm_to_int(scm_call_1 (layout_proc, pitch));
> +      }
> +      else {
> +     pos = pit->steps ();
> +      }

please follow coding conventions of the rest of the code, wrt spaces
and indents. In the last case, there are no braces.

> +             /* read */ "middleCPosition "
> +             "staffLineLayout",

use a space before the closing "

> index 0197dfe..e5de56d 100644
> --- a/scm/define-context-properties.scm
> +++ b/scm/define-context-properties.scm
> @@ -380,6 +380,7 @@ up the interpretation phase. This speeds up debugging 
> large scores.")
>       (squashedPosition ,integer? " Vertical position of
>  squashing for @internalsref{Pitch_squash_engraver}.")
>  
> +     (staffLineLayout ,procedure? "Layout of staff lines, 'traditional, or 
> 'semitone.")

naming should convey that this is a function.


-- 

Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen