[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patches for fret-diagrams update.

From: Han-Wen Nienhuys
Subject: Re: Patches for fret-diagrams update.
Date: Sun, 29 Jul 2007 09:20:52 -0700

2007/7/29, Han-Wen Nienhuys <address@hidden>:
> 2007/7/25, Carl D. Sorensen <address@hidden>:
> > I've completed the fret-diagrams refactoring, that puts all properties
> > that are specific to fret-diagrams into the fret-diagram-details
> > property.  Patches are attached.  I have included a new regression test
> > file because the syntax has changed so dramatically.

> thanks for the patches. I've pushed a preliminary version to the
> csorensen branch on I haven't looked in detail yet,
> but could you replace the assoc-set! calls that you use with
> non-destructive ones? Your version will modify the base definitions in
> the grob with settings from the parse string. The recommended approach
> is to tack ona new alist in front of the alist-chain.

Also, can you send future patches against the csorensen branch? Thanks!

(you might want to download a version of git for windows and/or cygwin
so you generate the patches with commit messages directly).

Han-Wen Nienhuys - address@hidden -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]