lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] musicxml2ly patches revisited


From: Han-Wen Nienhuys
Subject: Re: [PATCHES] musicxml2ly patches revisited
Date: Mon, 20 Aug 2007 00:58:02 -0300
User-agent: Thunderbird 2.0.0.5 (X11/20070719)

Reinhold Kainhofer escreveu:
> Next round of patches: After Han-Wens comments about coding style (no 
> exceptions, spaces, etc.), I reworked all my patches so far. Here they are 
> all again:

Thanks, I've applied them now. 

Some minor comments; I would appreciate if you address them before sending more
patches.

 {}.get

takes a default argument, so

 f = dict.get(key)
 if f:
   return f
 else: 
   return ''

can be shorter written as

  return dict.get(key, '')

 - not):
+        # +tied | +slur | +tuplet | glissando | slide | 
+             # ornaments | technical | articulations | dynamics |
+             # +fermata | arpeggiate | non-arpeggiate | 
+             # accidental-mark | other-notation

can you put indents inside the comments,  

  # foo 
  #     bar

+                if wedgetypeval != None:

better:

 if wedgetypeval:



-- 

Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen





reply via email to

[Prev in Thread] Current Thread [Next in Thread]